Skip to content

add "container" prop to Cartesian #197

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
johno merged 4 commits into from
Jun 23, 2018
Merged

add "container" prop to Cartesian #197

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
4206bf1
add "container" prop to Cartesian
VinSpee Jun 23, 2018
22fe236
move key to the container
VinSpee Jun 23, 2018
e1b0487
default container to `Fragment`
VinSpee Jun 23, 2018
10e67d6
cover `Cartesian`'s `container` prop with a test
Jun 23, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
42 changes: 31 additions & 11 deletions core/__tests__/Cartesian.js
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,25 +1,45 @@
import React from 'react'
import styled from 'styled-components'
import { render } from 'react-testing-library'
import { color, space, fontSize } from 'styled-system'
import React from 'react';
import styled from 'styled-components';
import { render } from 'react-testing-library';
import { color, space, fontSize } from 'styled-system';

import { Cartesian } from '../src'
import { Cartesian } from '../src';

const buttonProps = {
children: 'Hello, world!',
fontSize: [1, 2, 3],
px: [2, 3],
backgroundColor: ['pink', 'tomato', 'purple']
}
backgroundColor: ['pink', 'tomato', 'purple'],
};

const Button = styled.a`
${color}
${fontSize}
${space}
`
`;

const Container = styled.div`
padding: 1rem;
`;

test('Cartesian renders all examples', () => {
const { container } = render(<Cartesian {...buttonProps} component={Button} />)
const { container } = render(
<Cartesian {...buttonProps} component={Button} />,
);

expect(container).toMatchSnapshot();
});

test('Cartesian renders all examples in a container', () => {
const { getByTestId, container } = render(
<Cartesian
{...buttonProps}
component={Button}
container={() => <Container data-testid="container" />}
/>,
);

expect(container).toMatchSnapshot()
})
const containerNode = getByTestId('container');
expect(containerNode.nodeName).toBe('DIV');
expect(container).toMatchSnapshot();
});
77 changes: 77 additions & 0 deletions core/__tests__/__snapshots__/Cartesian.js.snap
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -112,3 +112,80 @@ exports[`Cartesian renders all examples 1`] = `
</a>
</div>
`;

exports[`Cartesian renders all examples in a container 1`] = `
<div>
<div
class="sc-bwzfXH UBTUY"
data-testid="container"
/>
<div
class="sc-bwzfXH UBTUY"
data-testid="container"
/>
<div
class="sc-bwzfXH UBTUY"
data-testid="container"
/>
<div
class="sc-bwzfXH UBTUY"
data-testid="container"
/>
<div
class="sc-bwzfXH UBTUY"
data-testid="container"
/>
<div
class="sc-bwzfXH UBTUY"
data-testid="container"
/>
<div
class="sc-bwzfXH UBTUY"
data-testid="container"
/>
<div
class="sc-bwzfXH UBTUY"
data-testid="container"
/>
<div
class="sc-bwzfXH UBTUY"
data-testid="container"
/>
<div
class="sc-bwzfXH UBTUY"
data-testid="container"
/>
<div
class="sc-bwzfXH UBTUY"
data-testid="container"
/>
<div
class="sc-bwzfXH UBTUY"
data-testid="container"
/>
<div
class="sc-bwzfXH UBTUY"
data-testid="container"
/>
<div
class="sc-bwzfXH UBTUY"
data-testid="container"
/>
<div
class="sc-bwzfXH UBTUY"
data-testid="container"
/>
<div
class="sc-bwzfXH UBTUY"
data-testid="container"
/>
<div
class="sc-bwzfXH UBTUY"
data-testid="container"
/>
<div
class="sc-bwzfXH UBTUY"
data-testid="container"
/>
</div>
`;
11 changes: 8 additions & 3 deletions core/src/Cartesian.js
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,13 +1,18 @@
import React, { Fragment } from 'react'
import { cartesianProduct } from './util'

export default ({ component, ...props }) => {
export default ({ component, container = Fragment, ...props }) => {
const combinations = cartesianProduct(props)
const Component = component

const Container = container

return (
<Fragment>
{combinations.map((props, i) => <Component key={i} {...props} />)}
{combinations.map((props, i) => (
<Container key={i} >
<Component {...props} />
</Container>
))}
</Fragment>
)
}