Skip to content

Allow omitting unit #36

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
caarlos0 merged 2 commits into from
Sep 19, 2022
Merged

Allow omitting unit #36

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
71032cf
Add "s" to arg[0] if it was a number without unit
lucassperez Sep 17, 2022
31a44b1
Add default time unit information to README
lucassperez Sep 19, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 6 additions & 1 deletion README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@

---

Timer is a small CLI, similar to the `sleep` everyone already knows and love,
Timer is a small CLI, similar to the `sleep` everyone already knows and love,
with a couple of extra features:

- a progress bar indicating the progression of said timer
Expand All @@ -22,6 +22,11 @@ man timer
timer --help
```

It is possible to pass a time unit for `<duration>`.

Valid time units are "ns", "us" (or "µs"), "ms", "s", "m", "h".
If no unit is passed, it defaults to seconds ("s").

## Install

**homebrew**:
Expand Down
9 changes: 9 additions & 0 deletions main.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,6 +3,7 @@ package main
import (
"fmt"
"os"
"strconv"
"time"

"github.com/charmbracelet/bubbles/key"
Expand Down Expand Up @@ -112,6 +113,7 @@ var rootCmd = &coral.Command{
SilenceUsage: true,
Args: coral.ExactArgs(1),
RunE: func(cmd *coral.Command, args []string) error {
addSuffixIfArgIsNumber(&(args[0]), "s")
duration, err := time.ParseDuration(args[0])
if err != nil {
return err
Expand Down Expand Up @@ -156,3 +158,10 @@ func main() {
os.Exit(1)
}
}

func addSuffixIfArgIsNumber(s *string, suffix string) {
_, err := strconv.ParseFloat(*s, 64)
if err == nil {
*s = *s + suffix
}
}