Skip to content

[BUG] forget() silently continues after state check failure #124

@cachebag

Description

@cachebag

Describe the bug
During forget() operation, if getting device state fails in the wait loop, the error is logged but the loop just breaks and continues to the deletion phase. This means we proceed without confirming the device actually disconnected.

Err(e) => {
    warn!("Failed to get device state in wait loop {i}: {e}");
    break;  // Continues to line 167 (deletion phase)
}

If the D-Bus call fails, we don't know if the device disconnected or is still connected.

Expected behavior
Should return the error or verify final state before proceeding to delete saved connections.

Metadata

Metadata

Assignees

No one assigned

    Labels

    bugSomething isn't workinggood first issueGood for newcomersnmrsChanges to nmrs

    Projects

    No projects

    Milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions