[BUG] nmrs concurrency protection

[cachebag]

Multiple simultaneous calls to connect() on the same NetworkManager instance could interfere with each other.

If two tasks try to connect to different networks simultaneously, they might both try to disconnect the device, race on activation or interfere with each other's state monitoring.

Some of the things I'm thinkig of:

• Add internal mutex/lock for connection operations
• Consider adding a is_connecting() method

We should probably add documentation for now that concurrent connections are not supported since I don't think I'm gonna tackle this quite yet.

[shubhsingh5901]

Hi @cachebag , I am thinking of working on this issue. As discussed on discord. Is it ok ?

[cachebag]

@shubhsingh5901 Go ahead!

[shubhsingh5901]

Hi @cachebag,

As you suggested, adding an is_connecting method to check the network state sounds like a good idea.

We can check the device state, and if it is in an intermediate (in-progress) state,
we will get one of these codes:

• NM_DEVICE_STATE_PREPARE (40),
• NM_DEVICE_STATE_CONFIG (50),
• NM_DEVICE_STATE_NEED_AUTH (60),
• NM_DEVICE_STATE_IP_CONFIG (70),
• NM_DEVICE_STATE_IP_CHECK (80),
• NM_DEVICE_STATE_SECONDARIES (90),
• NM_DEVICE_STATE_DEACTIVATING (110).

In that case, is_connecting can return true and we can avoid touching the device while another operation is in progress.

Reference for device states:
https://networkmanager.dev/docs/api/latest/nm-dbus-types.html

Let me know what you think about this approach.

[cachebag]

Hi @cachebag,

As you suggested, adding an is_connecting method to check the network state sounds like a good idea.

We can check the device state, and if it is in an intermediate (in-progress) state,
we will get one of these codes:

• NM_DEVICE_STATE_PREPARE (40),
• NM_DEVICE_STATE_CONFIG (50),
• NM_DEVICE_STATE_NEED_AUTH (60),
• NM_DEVICE_STATE_IP_CONFIG (70),
• NM_DEVICE_STATE_IP_CHECK (80),
• NM_DEVICE_STATE_SECONDARIES (90),
• NM_DEVICE_STATE_DEACTIVATING (110).

In that case, is_connecting can return true and we can avoid touching the device while another operation is in progress.

Reference for device states:
https://networkmanager.dev/docs/api/latest/nm-dbus-types.html

Let me know what you think about this approach.

Makes sense to me!

[shubhsingh5901]

Great, Then I will move ahead with this approach.