Skip to content

fix(config): correct binary name for desktop file + postInstall hook for Nix flake#146

Merged
cachebag merged 2 commits intocachebag:masterfrom
JonnieCache:desktop-fix
Dec 19, 2025
Merged

fix(config): correct binary name for desktop file + postInstall hook for Nix flake#146
cachebag merged 2 commits intocachebag:masterfrom
JonnieCache:desktop-fix

Conversation

@JonnieCache
Copy link
Contributor

@JonnieCache JonnieCache commented Dec 19, 2025

This fixes the Exec statement in the .desktop file to the correct nmrs-gui binary name.

Also it adds a postInstall hook to the nix flake to copy said desktop file to the correct place.

@JonnieCache
Copy link
Contributor Author

Hmm my editor appears to have autoformatted the flake file - let me know if that's a problem and I'll revert it.

Copy link
Owner

@cachebag cachebag left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Much appreciated! Just one nit regarding the hygiene of the PR: could you format the commits as "fix: blah blah"? In this case something like "fix(config): ..." or "feat(config): ...".

@cachebag cachebag added bug Something isn't working config labels Dec 19, 2025
@JonnieCache JonnieCache requested a review from cachebag December 19, 2025 13:27
Copy link
Owner

@cachebag cachebag left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@cachebag cachebag changed the title Fix desktop file fix(config): Correct binary name for desktop file + postInstall hook for Nix flake Dec 19, 2025
@cachebag cachebag changed the title fix(config): Correct binary name for desktop file + postInstall hook for Nix flake fix(config): correct binary name for desktop file + postInstall hook for Nix flake Dec 19, 2025
@cachebag cachebag merged commit 447ddbe into cachebag:master Dec 19, 2025
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants