perf: borrowed slice adjusted for empty ssid check#154
Merged
Conversation
There was a problem hiding this comment.
Pull request overview
This PR optimizes the decode_ssid_or_empty function by changing its return type from String to Cow<'static, str> to reduce allocations by returning borrowed slices when possible. The function is used for SSID comparison throughout the codebase, and avoiding allocations can improve performance.
- Changed
decode_ssid_or_emptyreturn type fromStringtoCow<'static, str> - Updated call sites to convert
CowtoStringwhere needed using.to_string()
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| nmrs/src/util/utils.rs | Modified decode_ssid_or_empty to return Cow<'static, str> instead of String, returning Cow::Borrowed("") for empty/invalid cases and Cow::Owned(s.to_owned()) for valid UTF-8 |
| nmrs/src/monitoring/info.rs | Updated two call sites to convert the Cow return value to String using .to_string() where String is required by the function signature |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Change
decode_ssid_or_emptyto return a borrowed slice instead ofString