refactor(nmrs): unify connection builder pattern#161
Merged
Conversation
cachebag
added
feature
cachebag
force-pushed
the
refactor/builder
branch
from
98749f2 to
32aa572
Compare
cachebag
force-pushed
the
refactor/builder
branch
from
32aa572 to
782863c
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR refactors connection builders to use a unified architecture that should help us expand upon new types in the future.
Changes
support
Also worth noting:
build_wifi_connection()- delegates toWifiConnectionBuilderbuild_ethernet_connection()- usesConnectionBuilderdirectlybuild_wireguard_connection()- delegates toWireGuardBuilderExisting API's are of course, unchanged and thus, fully backward compatible.