fix: replace magic number with named constant for device activation states#230
Merged
cachebag merged 1 commit intocachebag:masterfrom Jan 24, 2026
Merged
fix: replace magic number with named constant for device activation states#230cachebag merged 1 commit intocachebag:masterfrom
cachebag merged 1 commit intocachebag:masterfrom
Conversation
cachebag
requested changes
Jan 24, 2026
Owner
There was a problem hiding this comment.
This looks fine but can you please read the contributing guidelines
Specifically here, the commit message should be:
fix(#229): replace magic number with named constantEnsure you simply amend this commit and just change the message, do not make a new commit.
Owner
|
@AK78gz I am talking about the commit message, not the PR description or title. You need to run something like: git commit --amend
<change title to: fix(#229): replace magic number with named constant>
git push --force |
Contributor
Author
|
i didnt write that when i made the changes it appeared like this TT |
cachebag
requested changes
Jan 24, 2026
cachebag
requested changes
Jan 24, 2026
Owner
cachebag
left a comment
There was a problem hiding this comment.
You've made two commits but this change should be contained into one commit. Please start an interactive rebase and squash them into one commit.
cachebag
requested changes
Jan 24, 2026
cachebag
approved these changes
Jan 24, 2026
Owner
cachebag
left a comment
There was a problem hiding this comment.
Thanks for your patience! Appreciate the contribution :)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix(#229): Replace magic number 100 with named constant