refactor(#289): connect_vpn sig and new VpnConfig trait#303
Merged
cachebag merged 1 commit intodev-openvpnfrom Mar 19, 2026
Merged
refactor(#289): connect_vpn sig and new VpnConfig trait#303cachebag merged 1 commit intodev-openvpnfrom
connect_vpn sig and new VpnConfig trait#303cachebag merged 1 commit intodev-openvpnfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds
VpnConfig, introducesWireGuardConfigas the preferredWireGuardmodel, and deprecatedVpnCredentialswhile keeping it compatible viaVpnConfigplus conversion bridges in our vpn module.NetworkManager::connect_vpnnow accepts anyC: VpnConfig + Into<VpnCredentials>and the docs/examples were updated to use
WireGuardConfigin the facade and lib. I also re-exportedVpnConfigandWireGuardConfigfrom the crate root.Also added coverage for the new type and trait compatibility in our models tests and suppressed internal deprecation noise only in legacy plumbing so downstream users still get the deprecation signal when they use
VpnCredentials.Closes #289