Allow for empty properties in dotnet msbuild#4165
Merged
devlead merged 1 commit intoMar 8, 2026
Merged
Conversation
Contributor
Author
|
@microsoft-github-policy-service agree |
augustoproiete
previously requested changes
Jun 6, 2023
Member
augustoproiete
left a comment
augustoproiete
left a comment
There was a problem hiding this comment.
Thanks for the PR @Zulu-Inuoe
Overall looks good, but there's at least one test failing (which expects the old behavior). Could you take a look and amend the test(s) (or delete if doesn't make sense anymore)?
Actual: (null)
Stack Trace:
at Cake.Common.Tests.Unit.Tools.DotNet.MSBuild.DotNetMSBuildBuilderTests.TheBuildMethod.Should_Throw_If_Property_Has_No_Value(String[] propertyValues) in D:\a\1\s\src\Cake.Common.Tests\Unit\Tools\DotNet\MSBuild\DotNetMSBuildBuilderTests.cs:line 204
at System.RuntimeMethodHandle.InvokeMethod(Object target, Void** arguments, Signature sig, Boolean isConstructor)
at System.Reflection.MethodInvoker.Invoke(Object obj, IntPtr* args, BindingFlags invokeAttr)
Failed Cake.Common.Tests.Unit.Tools.DotNet.MSBuild.DotNetMSBuildBuilderTests+TheBuildMethod.Should_Throw_If_Property_Has_No_Value(propertyValues: [""]) [< 1 ms]
Error Message:
Assert.IsType() Failure
Expected: System.ArgumentException
Member
|
Hey @Zulu-Inuoe just following up on this one. Will you be able to get this to the finish line? |
devlead
force-pushed
the
bugfix/empty-params-in-msbuild
branch
from
5301bb4 to
e4aa6f7
Compare
devlead
approved these changes
Mar 8, 2026
Member
devlead
left a comment
devlead
left a comment
There was a problem hiding this comment.
Addressed the failing test.
LGTM 👍
Member
|
@Zulu-Inuoe your changes have been merged, thanks for your contribution 👍 |
This was referenced May 22, 2026
This was referenced May 25, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #4158