Added SupportedOSPlatform property to AssemblyInfoSettings.#4725
Merged
devlead merged 2 commits intocake-build:developfrom Feb 25, 2026
Merged
Conversation
squid-box
force-pushed
the
feature/AssemblyInfo-Multiple-CustomAttributes
branch
from
a03587e to
a80b3de
Compare
squid-box
force-pushed
the
feature/AssemblyInfo-Multiple-CustomAttributes
branch
from
a80b3de to
a4726a9
Compare
devlead
force-pushed
the
feature/AssemblyInfo-Multiple-CustomAttributes
branch
from
a4726a9 to
4634dfe
Compare
- Add SupportedOSPlatform to AssemblyInfoParseResult and parse it in AssemblyInfoParser (same pattern as InternalsVisibleTo) - Extend parser fixtures (C# and VB) with SupportedOSPlatform for tests - Add unit tests: Should_Read_SupportedOSPlatform and Should_Read_Multiple_SupportedOSPlatform - In integration tests: assert ParseAssemblyInfo returns SupportedOSPlatform and add CreateAssemblyInfoWithSupportedOSPlatform and CreateAssemblyInfoWithMultipleSupportedOSPlatform tasks
devlead
force-pushed
the
feature/AssemblyInfo-Multiple-CustomAttributes
branch
from
453e5da to
a425fab
Compare
Member
|
@squid-box your changes have been merged, thanks for your contribution 👍 |
Contributor
Author
|
Thank you, and sorry for completely missing the AssemblyInfoParser and integration tests 🙈 |
This was referenced Mar 1, 2026
This was referenced Mar 2, 2026
This was referenced Mar 2, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This fixes #4071 by introducing a new property to AssemblyInfoSettings.
It seemed more correct to introduce a new property rather than trying to alter the behavior of how
CustomAttributesare handled, but I'm not dead set on this implementation if there is a better suggestion.My main reasoning is that this will not break any existing setup which uses
CustomAttributesto apply the SupportedOSPlatform attribute, but it enables what I need (to specify multiple platforms).