Add translation() => getOrCreateTranslation() rector rule for 6.x#388
Open
dereuromark wants to merge 1 commit into6.xfrom
Open
Add translation() => getOrCreateTranslation() rector rule for 6.x#388dereuromark wants to merge 1 commit into6.xfrom
dereuromark wants to merge 1 commit into6.xfrom
Conversation
In CakePHP 6.0, TranslateTrait::translation() becomes a pure getter
that returns null if no translation exists. The old create-on-access
behavior is now in getOrCreateTranslation().
This rector transforms $entity->translation('lang') calls to
$entity->getOrCreateTranslation('lang') to preserve backward
compatibility during the upgrade.
See: cakephp/cakephp#19251
dereuromark
force-pushed
the
feature/translation-rector-6x
branch
from
f23c6b0 to
c225d66
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds a Rector rule for CakePHP 6.0 that transforms
$entity->translation('lang')calls to$entity->getOrCreateTranslation('lang').In CakePHP 6.0,
TranslateTrait::translation()becomes a pure getter that returnsnullif no translation exists. The old create-on-access behavior (creating an empty translation entity and marking it dirty) is now ingetOrCreateTranslation().This rector rule preserves backward compatibility by renaming
translation()calls togetOrCreateTranslation(), which maintains the same behavior as before the change.Before:
After:
Refs: cakephp/cakephp#19251