-
Notifications
You must be signed in to change notification settings - Fork 11.8k
fix: stabilize date range calculation in column view #25384
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: stabilize date range calculation in column view #25384
Conversation
|
@kartik-212004 is attempting to deploy a commit to the cal Team on Vercel. A member of the Team first needs to authorize it. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
1 issue found across 1 file
Prompt for AI agents (all 1 issues)
Understand the root cause of the following 1 issues and fix them.
<file name="packages/features/bookings/Booker/Booker.tsx">
<violation number="1" location="packages/features/bookings/Booker/Booker.tsx:184">
Removing the eslint-disable for `@calcom/eslint/no-scroll-into-view-embed` leaves this `scrollIntoViewSmooth` call violating a rule that is still configured as an error, so the Booker build will now fail linting.</violation>
</file>
Reply to cubic to teach it or ask questions. Re-run a review with @cubic-dev-ai review this PR
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No issues found across 1 file
pallava-joshi
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
tested locally too
E2E results are ready! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No issues found across 1 file
dhairyashiil
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good!
Thank you for the PR Kartik, and thanks to Pallav for testing it locally.
What does this PR do?
This PR fixes a UI flickering issue in the
Column Viewon the booking page.When the number of available slots exactly matched the number of columns to display (e.g. 6 days), the date range calculation would enter an infinite loop, alternating between showing the correct range and an extended range (adding an extra week).
Visual Demo
Before:
awdawd._.Enterprise.Member.1._.Cal.com.-.25.November.2025.1.mp4
After:
awdawd._.Enterprise.Member.1._.Cal.com.-.25.November.2025.mp4
Mandatory Tasks
How should this be tested?