Skip to content

Conversation

@kartik-212004
Copy link
Contributor

What does this PR do?

This PR fixes a UI flickering issue in the Column View on the booking page.
When the number of available slots exactly matched the number of columns to display (e.g. 6 days), the date range calculation would enter an infinite loop, alternating between showing the correct range and an extended range (adding an extra week).

Visual Demo

Before:

awdawd._.Enterprise.Member.1._.Cal.com.-.25.November.2025.1.mp4

After:

awdawd._.Enterprise.Member.1._.Cal.com.-.25.November.2025.mp4

Mandatory Tasks

  • I have self-reviewed the code.
  • N/A
  • I confirm automated tests are in place that prove my fix is effective or that my feature works.

How should this be tested?

  1. Open a booking page with "Column View" enabled.
  2. Navigate to a week where there are exactly enough available days to fill the columns (e.g, 6 days for desktop).
  3. Observe the date range header.
  4. Verify that it does not flicker and shows the correct date range.

@vercel
Copy link

vercel bot commented Nov 25, 2025

@kartik-212004 is attempting to deploy a commit to the cal Team on Vercel.

A member of the Team first needs to authorize it.

@graphite-app graphite-app bot added the community Created by Linear-GitHub Sync label Nov 25, 2025
@github-actions github-actions bot added High priority Created by Linear-GitHub Sync 🐛 bug Something isn't working labels Nov 25, 2025
Copy link
Contributor

@cubic-dev-ai cubic-dev-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

1 issue found across 1 file

Prompt for AI agents (all 1 issues)

Understand the root cause of the following 1 issues and fix them.


<file name="packages/features/bookings/Booker/Booker.tsx">

<violation number="1" location="packages/features/bookings/Booker/Booker.tsx:184">
Removing the eslint-disable for `@calcom/eslint/no-scroll-into-view-embed` leaves this `scrollIntoViewSmooth` call violating a rule that is still configured as an error, so the Booker build will now fail linting.</violation>
</file>

Reply to cubic to teach it or ask questions. Re-run a review with @cubic-dev-ai review this PR

Copy link
Contributor

@cubic-dev-ai cubic-dev-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No issues found across 1 file

pallava-joshi
pallava-joshi previously approved these changes Nov 25, 2025
Copy link
Member

@pallava-joshi pallava-joshi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

tested locally too

@github-actions
Copy link
Contributor

github-actions bot commented Nov 25, 2025

E2E results are ready!

Copy link
Contributor

@cubic-dev-ai cubic-dev-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No issues found across 1 file

Copy link
Member

@dhairyashiil dhairyashiil left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!
Thank you for the PR Kartik, and thanks to Pallav for testing it locally.

@dhairyashiil dhairyashiil merged commit ce279da into calcom:main Nov 29, 2025
33 of 37 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

🐛 bug Something isn't working community Created by Linear-GitHub Sync High priority Created by Linear-GitHub Sync ready-for-e2e size/S

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Booker: Excessive Re-renders in Column View Cause Flickering Date Range & Incorrect Week Calculation

3 participants