refactor(tests): reduce duplication in organizations-users e2e #25645
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- avatarValidator: accept URLs in addition to base64 images
- organizations-users-service: use email for user creation instead of username
The avatarValidator was incorrectly rejecting valid URLs even though the API documentation shows URL examples and all e2e tests use URLs.
The user creation was failing when username was provided because createNewUsersConnectToOrgIfExists requires a valid email, not username. The username is correctly applied via updateOrganizationUser after creation.
Fixes user creation endpoint POST /v2/organizations/{orgId}/users
Add comprehensive test coverage for avatarValidator changes: - Unit tests: 18 scenarios covering valid/invalid URLs and base64 images - E2E tests: user creation with username + avatarUrl (URL and base64) - Security validation: reject unsafe protocols and malformed data - Error message verification for validation failures Addresses testing requirements from code review
- Preparing for complete test file rewrite to improve maintainability, reduce code duplication while preserving test coverage
…lpers - Add org-user.helper.ts with createOrgUser and cleanupOrgTest functions - Rewrite organizations-users.e2e-spec.ts with improved structure and DRY principles - Reduce code duplication while preserving test coverage - Add factory functions and enhanced assertions for better maintainability
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Refactors
organizations-users.e2e-spec.tsto reduce duplication and improve maintainability.Problem:
membershipFixturesvsprofileRepositoryFixture)Key Changes:
org-user.helper.ts: New helper withcreateOrgUser()andcleanupOrgTest()*Fixture(singular)afterEachto restore mocks between testsResult: 891 → 582 lines, helper adds 62 lines.
How should this be tested?
Run the test:
All 17 tests should pass. No behavior changes, same coverage.
Mandatory Tasks