refactor: Move Users Admin TRPC router from features package to trpc layer #25816
+47
−32
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hbjORbj
changed the title
hbjORbj
commented
Dec 12, 2025
Comment on lines
+15
to
+16
| interface User { | ||
| id: number; |
Contributor
Author
There was a problem hiding this comment.
creating a type rather than coupling with UserAdminRouterOutputs which exists in trpc package now
hbjORbj
commented
Dec 12, 2025
| type FormValues = Pick< | ||
| User, | ||
| "avatarUrl" | "name" | "username" | "email" | "bio" | "createdDate" | "theme" | "defaultScheduleId" | "allowDynamicBooking" | ||
| | "avatarUrl" |
Contributor
Author
There was a problem hiding this comment.
just formatting changes
hbjORbj
commented
Dec 12, 2025
| </LicenseRequired> | ||
| ); | ||
| }; | ||
| interface User { |
Contributor
Author
There was a problem hiding this comment.
creating a type rather than coupling with UserAdminRouterOutputs which exists in trpc package now
![cubic-dev-ai[bot]](https://avatars.githubusercontent.com/in/1082092?s=60&v=4){kind=small}
hbjORbj
commented
Dec 12, 2025
Comment on lines
-18
to
-20
| const userIdSchema = z.object({ id: z.coerce.number() }); | ||
|
|
||
| const UsersEditPage = () => { |
keithwillcode
approved these changes
Dec 14, 2025
| weekStart: string; | ||
| theme: string | null; | ||
| defaultScheduleId: number | null; | ||
| locale: string; |
Contributor
There was a problem hiding this comment.
Build failed because locale is nullable in the database schema
| weekStart: string; | ||
| theme: string | null; | ||
| defaultScheduleId: number | null; | ||
| locale: string; |
Contributor
There was a problem hiding this comment.
Build failed because locale is nullable in the database schema
Contributor
|
Build failed because locale is nullable in the database schema |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Moves the
userAdminRouterfrompackages/features/ee/users/server/trpc-router.tstopackages/trpc/server/routers/viewer/users/_router.tsto follow the standard tRPC router organization pattern.Why?
This removes cross-package coupling by replacing imported types with local interfaces as well as circular dependencies where features layer import trpc layer
Changes
userAdminRoutertopackages/trpc/server/routers/viewer/users/_router.tsviewer/_router.tsxand/api/trpc/usershandlerUserAdminRouterOutputstype dependency with localUserinterface inUserForm.tsxandusers-edit-view.tsxUsersEditViewto accept aUserprop directly (removed page-level wrappers)Mandatory Tasks (DO NOT REMOVE)