Add text editor for custom email bodies (custom workflow template)#5197
Closed
CarinaWolli wants to merge 23 commits intomainfrom
Closed
Add text editor for custom email bodies (custom workflow template)#5197CarinaWolli wants to merge 23 commits intomainfrom
CarinaWolli wants to merge 23 commits intomainfrom
Conversation
added 19 commits
October 19, 2022 18:43
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
alannnc
reviewed
Oct 25, 2022
Contributor
alannnc
left a comment
There was a problem hiding this comment.
Looks good and it works! But I'm not sure about using a project that it's already on maintenance mode and soon to be archived.
Also we need to consider this:

Looks like it's no fully supported on ios or android.
They suggest to take a look on https://github.com/facebook/lexical
Member
Author
I am trying out lexical right now, I'll make this PR a draft for now |
1 task
Member
Author
|
Used facebook/lexical instead of draft.js #5654 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Adds a text editor to create better custom email bodies.
Fixes:
First step of making workflow templates more flexible (#4944)
Loom Video: https://www.loom.com/share/a56df63342434a0a9727e8f770cc4c7b
Environment: Staging(main branch)
Type of change
How should this be tested?