Fix black background on android#228
Merged
Naturalclar merged 1 commit intocallstack:masterfrom Nov 3, 2024
Merged
Conversation
crashzky
approved these changes
Sep 17, 2024
|
LGTM |
samueljim
approved these changes
Oct 10, 2024
|
I'm currently using this in my package.json for all those who need this fix |
|
BUMP |
AliRezaBeigy
approved these changes
Nov 3, 2024
There was a problem hiding this comment.
as @samueljim tested it's ok
i test it too and the black background issue goes away
@Naturalclar can you merge these change?
janicduplessis
added a commit
to rainbow-me/masked-view
that referenced
this pull request
Jan 10, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Overview
Closes #226
Calling
setLayerTypefromsetRenderingModeand passing null as the paint reference will cause the default paint to be used which will have it'sPorterDuffXfermodeset toSRC_OVER. This causes the incorrect result.I've added a new
mRenderingModeproperty that is used to callsetLayerTypefromdispatchDrawwhere we have a paint reference with the correct PorterDuffXfermode set.Test Plan
I've updated the example app to use 0.75 and tested both platforms on both architectures.