Load Android Gradle Plugin conditionally#56
Closed
SaeedZhiany wants to merge 1 commit intocallstack:masterfrom
SaeedZhiany:patch-1
Closed
Load Android Gradle Plugin conditionally#56SaeedZhiany wants to merge 1 commit intocallstack:masterfrom SaeedZhiany:patch-1
SaeedZhiany wants to merge 1 commit intocallstack:masterfrom
SaeedZhiany:patch-1
Conversation
Author
|
Please review and merge this. Thanks |
Collaborator
|
Thanks for this PR. Changes were added into #60 |
Author
|
Nice, I just checked that PR, you could also bump the AGP version to |
Collaborator
|
@SaeedZhiany There is a need to bump the AGP version? |
Author
|
No actually, with the condition, users' projects will ignore this library's AGP version and it's no matter for their projects. I suggest bumping the version to keep the library's dependency up-to-date. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This wraps the Android Gradle plugin dependency in the buildscripts section of android/build.gradle in a conditional:
The Android Gradle plugin is only required when opening the project stand-alone, not when it is included as a dependency. By doing this, the project opens correctly in Android Studio, and it can also be consumed as a native module dependency from an application project without affecting the app project (avoiding unnecessary downloads/conflicts/etc).
for more info, you can refer to this thread and especially this comment.
Test Plan
Suppose you use this library on a project that has a different AGP version than this library's AGP version and the latter one is not installed on the OS. by this change, the library's AGP will not download during the build process (which it shouldn't be)
What's required for testing (prerequisites)?
An OS that has not installed the Android Gradle Plugin version that this library already using.
What are the steps to reproduce (after prerequisites)?
Just import this library in a project and run it on an Android emulator or a real device
Compatibility
Checklist
README.mdCHANGELOG.mdexample/App.js)