I18nManager becomes mock-only in react-native-web 0.18 - affect on react-native-paper?

[mikehardy]

I saw this in the react-native-web 0.18 pre-release necolas/react-native-web#2248

I18nManager is now a mock API included only for compatibility with React Native. The ability to swap between left/right values for RTL writing directions has been removed entirely. See below for new localization APIs.

...and I recall that in a PR I just did I was following some internal convention for handling RTL layouts here in react-native-paper: https://github.com/callstack/react-native-paper/pull/3015/files#diff-abbb75c84e06f0e76a8627a199ea73e45aee12d708f8f839d55603b2151466d9R136-R139

The combination of the two seems worrisome, it appears that if I am understanding the RNW 0.18 release notes correctly and "mock API" means we will get a static answer for I18nManager calls on web platform, then RTL will suffer a regression on web platform here until the new RNW APIs are handled?

If this is a problem, easiest forward-port might be to polyfill it back to old behavior on web platform, losing whatever enhancement drove the change but preserving current behavior. Complicated forward-port would involve understanding the enhancement and adapting behavior here accordingly

[github-actions]

Hey! Thanks for opening the issue. The issue doesn't seem to contain a link to a repro (a snack.expo.dev link or link to a GitHub repo under your username).

Can you provide a minimal repro which demonstrates the issue? A repro will help us debug the issue faster. Please try to keep the repro as small as possible and make sure that we can run it without additional setup.

[github-actions]

Couldn't find version numbers for the following packages in the issue:

• react-native
• react-native-paper
• react-native-vector-icons

Can you update the issue to include version numbers for those packages? The version numbers must match the format 1.2.3.

[github-actions]

Hello 👋, this issue has been open for more than a month without a repro or any activity. If the issue is still present in the latest version, please provide a repro or leave a comment within 7 days to keep it open, otherwise it will be closed automatically. If you found a solution or workaround for the issue, please comment here for others to find. If this issue is critical for you, please consider sending a pull request to fix it.

[mikehardy]

@lukewalczak I understand this is not actionable but I thought (as a fellow maintainer of complicated repos...) that this one might be important enough to at least take a look at. react-native-paper uses I18nmanager a lot...

[lukewalczak]

Hey @mikehardy, currently my focus is mainly on Material You and distributing the alpha version. I will reopen that issue and dive into it once have some time.

[mikehardy]

Totally understand (and seriously: thanks so much for the effort) I just wanted to make sure this wasn't a complete surprise for you later :-)

[mikehardy]

Just cross-pollinating, I thought this was an interesting PR from another native+web repo: https://github.com/react-navigation/react-navigation/pull/10547/files - basically they just converted I18NManager.isRTL to I18NManager.getConstants().isRTL ?

[lukewalczak]

Just cross-pollinating, I thought this was an interesting PR from another native+web repo: react-navigation/react-navigation#10547 (files) - basically they just converted I18NManager.isRTL to I18NManager.getConstants().isRTL ?

Hey @mikehardy, thanks for pointing it out. I will adjust it in the Paper codebase as well.

[lukewalczak]

PR adjust I18nManager.getConstants: #3352