feat: adjust theme types to match internal and regular usage #3279
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
@lukewalczak CircleCI tests fail due to missing implementation in |
lukewalczak
force-pushed
the
feat/adjust-overriding-theme-types
branch
from
7076433 to
ecf20ac
Compare
|
The mobile version of example app from this branch is ready! You can see it here |
Merged
|
The mobile version of example app from this branch is ready! You can see it here |
lukewalczak
reviewed
Oct 11, 2022
Member
lukewalczak
left a comment
lukewalczak
left a comment
There was a problem hiding this comment.
Small grammar suggestion and adding useTheme in example
Co-authored-by: Luke Walczak <lukasz.walczak.pwr@gmail.com>
Co-authored-by: Luke Walczak <lukasz.walczak.pwr@gmail.com>
|
The mobile version of example app from this branch is ready! You can see it here |
1 similar comment
|
The mobile version of example app from this branch is ready! You can see it here |
lukewalczak
force-pushed
the
feat/adjust-overriding-theme-types
branch
from
d205270 to
871a875
Compare
|
The mobile version of example app from this branch is ready! You can see it here |
|
The mobile version of example app from this branch is ready! You can see it here |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
During the development we came to the conclusion that
useThemeright now has to serve too many roles - support two themes at the same time for internal components and later on support just one theme when used by developers includingreact-native-paperinto their applicationsSummary
useInternalThemehook for internal usagewithInternalThemeHOC for internal usage@callstack/react-theme-providerto allow typing hooksTest plan
Due to the usage of global
index.d.tsfiles I had troubles with testing the implementation insideexamplefolder. My idea now is to create a separate app, includereact-native-paperfrom this branch and see if global theme overrides work properly