Dependency issue on pnpm monorepo with Expo app and `node-linker=hoisted`

[busybox11]

Documentation is

• Missing
• Outdated
• Confusing
• Not sure?

Explain in Detail

While trying to setup repack for an Expo app inside a pnpm monorepo, I had the following error:

error Named export 'openStackFrameInEditorMiddleware' not found. The requested module '@react-native-community/cli-server-api' is a CommonJS module, which may not support all module.exports as named exports.
CommonJS modules can always be imported via the default export, for example using:

import pkg from '@react-native-community/cli-server-api';
const { openStackFrameInEditorMiddleware, openURLMiddleware, } = pkg;
.
file:///home/busy/dev/VANGUARD/node_modules/@callstack/repack-dev-server/dist/plugins/devtools/devtoolsPlugin.js:1
import { openStackFrameInEditorMiddleware, openURLMiddleware, } from '@react-native-community/cli-server-api';
         ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
SyntaxError: Named export 'openStackFrameInEditorMiddleware' not found. The requested module '@react-native-community/cli-server-api' is a CommonJS module, which may not support all module.exports as named exports.
CommonJS modules can always be imported via the default export, for example using:

import pkg from '@react-native-community/cli-server-api';
const { openStackFrameInEditorMiddleware, openURLMiddleware, } = pkg;

    at ModuleJob._instantiate (node:internal/modules/esm/module_job:180:21)
    at async ModuleJob.run (node:internal/modules/esm/module_job:263:5)
    at async onImport.tracePromise.__proto__ (node:internal/modules/esm/loader:547:26)
    at async Object.start [as func] (/home/busy/dev/VANGUARD/node_modules/@callstack/repack/dist/commands/rspack/start.js:56:7)
    at async Command.handleAction (/home/busy/dev/VANGUARD/node_modules/@react-native-community/cli/build/index.js:139:9)

This was caused by @callstack/repack-dev-server requiring version 15.0.1 of @react-native-community/cli-server-api, but my Expo app already had version 18.0.0 installed because of its dependencies. This (probably) would've worked fine with non-hoisted modules.

This version does not export openStackFrameInEditorMiddleware under the same name anymore (it became openStackFrameMiddleware on v17.0.0 with this commit).

EDIT: While investigating further it looks like the whole module is exported differently.
In the case of docs change this doesn't really matter - but it could be useful for debugging.

---

I recognize this isn't the fault of repack, and it should not be treated as such - but it's a pitfall I could see many developers fall into without understanding the reason or thinking they did something wrong.

I believe it should be acknowledged somewhere in the documentation that it might not work "straight out of the box", especially with Expo or other miscellaneous wrappers that already depend on RN modules and thus will not allow complete control of repack dependencies versions.

Your Suggestion for Changes

I'm not sure how to word this, sorry.

I'm not even sure this is a good suggestion haha (sorry if it's not!).

[jbroma]

hey @busybox11 thanks for reporting this!

Upon closer inspection it doesn't make much sense to having @react-native-community/cli-server-api as a peer-dep, so in #1081 I've removed it altogether. This should resolve your issue altogether 👍

[jbroma]

fixed in 5.0.2

[busybox11]

Awesome, thanks!

I kind of figured it didn't, but the dependency issue could still occur. Hopefully it will not, although I remember seeing the same packages used both in Repack and Expo.

Will come back to you if it occurs again for some reason - for now I'm trying to make my app work with Repack at all haha.