Remove redundant parameter validation from private modules (_transformations.py, _functions.py)#155
Open
Savitha-Akhilu wants to merge 12 commits intocamUrban:mainfrom
Open
Remove redundant parameter validation from private modules (_transformations.py, _functions.py)#155Savitha-Akhilu wants to merge 12 commits intocamUrban:mainfrom
Savitha-Akhilu wants to merge 12 commits intocamUrban:mainfrom
Conversation
Remove the `ages` parameter from `collapsed_velocities_from_horseshoe_vortices` and `expanded_velocities_from_horseshoe_vortices` and update all call sites accordingly.
camUrban
added
maintenance
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Remove redundant parameter validation from private modules (_transformations.py, _functions.py)
Motivation
Private modules were performing parameter validation using _parameter_validation utilities.
Since these modules are only called internally with already validated inputs, these checks were unnecessary and added overhead.
Relevant Issues
Fixes #150
Changes
Dependency Updates
None
Change Magnitude
Minor
Checklist (check each item when completed or not applicable)
main.