Skip to content

Conversation

@maxl2287
Copy link
Contributor

What type of PR is this?

Add one of the following kinds:

  • correction

What this PR does / why we need it:

Sets the format for sink to uri.

Which issue(s) this PR fixes:

Fixes #269

@dfischer-tech
Copy link
Contributor

LGTM 🐈‍⬛

@bigludo7
Copy link
Collaborator

As the we have already released these 3 APIs with this version I guess we cannot change them?
We need to move back to wip and then craft a new release no?

@eric-murray
Copy link
Collaborator

Ideally, a separate PR resetting all version numbers to WIP would be merged first before this one (and any others)

I would not patch the previous release as it only affects the API response, and hence has no impact on clients. It can wait for the next release.

@akoshunyadi
Copy link
Collaborator

I think the fastest way would be to change the versions in the 3 affected files to wip here

@bigludo7
Copy link
Collaborator

I think the fastest way would be to change the versions in the 3 affected files to wip here

Works for me as we discussed during previous meeting to not switch all yaml to wip as we were not sure to update them for next release.

@maxl2287
Copy link
Contributor Author

maxl2287 commented May 2, 2025

@camaraproject/device-status_codeowners I have updated the touched APIs to version vwip

@maxl2287 maxl2287 added the Fall25 label May 7, 2025
Copy link
Collaborator

@bigludo7 bigludo7 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@maxl2287
Copy link
Contributor Author

@akoshunyadi I'll close this PR, as it's moved out into the new repositories.

@maxl2287 maxl2287 closed this Jun 11, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Change the event notification sink format from url to uri as well in the Subscription definition.

6 participants