-
Notifications
You must be signed in to change notification settings - Fork 2
admin: migrate to centralized linting workflows #36
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
admin: migrate to centralized linting workflows #36
Conversation
Applied via project-admin workflow Repository: PredictiveConnectivityData Operation: centralize-linting-workflows
🦙 MegaLinter status: ✅ SUCCESS
See detailed report in MegaLinter reports |
…ad the same scenario title as another scenario
…io-size to warnings. Updated ErrorInfo property order per CAMARA issue #515. Attached corrected Predictive ATP for public PR update.
|
Hi @hdamker , We’ve managed to reduce all validation errors down to the following: We’ve already shortened or refactored wherever possible, but in these remaining cases, reducing either the step names or the scenario length would compromise test coverage or clarity. I’ve tried several approaches and couldn’t find a clean way to simplify further. Would it be reasonable to suggest in the PR that these two rules (name-length and scenario-size) could be treated as warnings instead? Let me know what you think! Best, |
@albertoramosmonagas I'm not an expert for Gherkin files, therefore I don't know how important the checks are (maybe as tools using the code have similar restrictions). I would propose that you ask the question within a discussion or issue in Commonalities where the rules are defined. Short-term you might just ignore the errors, the check is not blocking the PR merge. Here some hints how to handle the points:
For example: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We have reduced the errors and now there are only a few remaining related to scenario size and name length, which we consider almost impossible to reduce without compromising part of the tests. For my part, it is approved because the check is not blocking the PR merge.
I am awaiting your approval, @eric-murray, to merge and move on to the public version.
If you merge this PR, you should then still fix the issues in a separate issue and PR. The issues will show up in in every PR, including the release PR - where the ReleaseManagement will insist either to fix them or to get a decision from Commonalities to relax the rules. On a personal note I don't agree that the issues can't be resolved without compromising part of the tests, it needs just some refactoring of the scenarios. |
e91b012
CAMARA Project Admin Update - Linting Migration
This pull request migrates this repository from local linting configuration to centralized linting workflows managed by the CAMARA project.
🔄 Migration Summary
Removed local linting artifacts:
megalinter.ymlspectral_oas_lint.yml.spectral.yml.yamllint.yaml.gherkin-lintrc/lint_function/Added centralized workflows:
spectral-oas-caller.yml- Spectral linting with CAMARA rulesetpr_validation_caller.yml- Comprehensive PR validation✨ Benefits of Centralized Linting
📋 What This Means for You
🔧 Technical Details
The new workflows reference reusable workflows from:
camaraproject/tooling/.github/workflows/This ensures all repositories benefit from:
👥 Next Steps for Codeowners
Before This PR Can Be Merged:
Review linting results in PR checks:
Fix linting errors directly in this PR:
Approve and merge this PR 🚀
After Successful Merge:
Monitor the new linting system:
Test with additional rules (optional):
Monitor future PRs:
💡Pro tip: Running the Spectral workflow manually NOW is highly recommended. This allows you to fix issues proactively rather than discovering them when submitting your next feature PR!
🤖 Generated via project-admin workflow
Triggered by hdamker, executed via hdamker-bot
➡️ Next Steps: This PR should be reviewed, fixed as needed, approved, and merged by repository codeowners following standard review processes.
This is a manually triggered automated administrative update.