Orthanc dicom server #212
Merged
Orthanc dicom server #212
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
birm
reviewed
Sep 18, 2023
Contributor
Author
|
The default DICOM configuration is to allow everything. Should I mention it in the README? |
Contributor
Author
|
Sorry @birm actually I remembered that to test Orthanc, you would need to change slideloader and caracal to point to my pull requests camicroscope/SlideLoader#84 camicroscope/Caracal#163 then DICOM explorer will be at (after camicroscope/caMicroscope#656 , there will be a button to it) |
birm
approved these changes
Sep 18, 2023
Member
birm
left a comment
birm
left a comment
There was a problem hiding this comment.
end to end test looks good. It'll be nice when we can collapse the file information to avoid having such a long table when using dicoms.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'm not touching keycloak and pathdb, because they seem to be related to permission handling and the dicom server needs a completely different auth setup.