Use our openslide #68
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
birm
approved these changes
Aug 1, 2023
Member
birm
left a comment
birm
left a comment
There was a problem hiding this comment.
I had to add dcm to the list of supported file types in slideserver, but now it looks good to me. Please let me know if you object to my change to your change :)
Contributor
Author
|
Nope, thanks for that! I cherry pick from my branch with lots of debug statements but this time I somehow left it out despite that I did test this clean patch - maybe not thoroughly enough. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Main discussion at: camicroscope/caMicroscope#647
To replace with openslide from apt, changing the first line back to python:3 is enough
--break-system-packagesis due to using an Ubuntu base image rather than a Python one.