Skip to content

Fixed keyboard accessibility issues on Workbench page #1016

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
birm merged 7 commits into from
Jul 29, 2024
Merged

Fixed keyboard accessibility issues on Workbench page #1016

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
70ed2b0
made nav buttons keyboard focusable
nwanduka Jul 22, 2024
a2022e6
Update workbench.html
nwanduka Jul 22, 2024
ce1fd78
styled options button for better contrast
nwanduka Jul 22, 2024
f6a65b2
Update workbench.html
nwanduka Jul 22, 2024
7ca8d8a
made first stepper button focus visible
nwanduka Jul 22, 2024
d8d6a57
Merge branch 'develop' into keyboard-focus
nwanduka Jul 29, 2024
536fe92
Update workbench.html
nwanduka Jul 29, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 18 additions & 0 deletions apps/dev-workbench/workbench.css
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -67,3 +67,21 @@
margin-left: 0 !important;
}
}
.navbar .nav-item .dropdown .options-button {
background-color: #000;
color: #fff;
border: none;
}

.focus-visible:focus-visible {
outline: 3px solid #000;
outline-offset: 2px;
box-shadow: 0 0 0 5px rgb(23, 162, 184);
}

/* For browsers that don't support :focus-visible */
.focus-visible:focus {
outline: 3px solid #000;
outline-offset: 2px;
box-shadow: 0 0 0 5px rgb(23, 162, 184);
}
19 changes: 12 additions & 7 deletions apps/dev-workbench/workbench.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -67,7 +67,7 @@
class="navbar navbar-expand-lg navbar-dark flex-row px-2"
style="background: rgb(33, 37, 41);"
>
<div style="cursor: pointer;" id="goBack">
<div style="cursor: pointer;" id="goBack" tabindex="0">
<i data-feather="arrow-left" class="text-white"></i>
</div>

Expand All @@ -88,11 +88,12 @@
class="nav-item dropdown"
>
<button
class="nav-link dropdown-toggle"
class="nav-link dropdown-toggle options-button"
id="navbarDropdownMenuLink"
data-toggle="dropdown"
aria-haspopup="true"
aria-expanded="false"
aria-label="Options dropdown"
>Options</button
>
<div
Expand All @@ -105,20 +106,24 @@
class="dropdown-item"
href="#"
style="display: none;"
><i class="fas fa-file-export"></i>&nbsp;&nbsp;Export</a
tabindex="0"
role="menuitem"
><i class="fas fa-file-export" aria-hidden="true"></i>&nbsp;&nbsp;Export</a
>
<a class="dropdown-item" href="#" onclick="importWork()"
><i class="fas fa-file-import"></i>&nbsp;&nbsp;Import</a
tabindex="0" role="menuitem"><i class="fas fa-file-import"></i>&nbsp;&nbsp;Import</a
>
<input type="file" id="importFile" />
<input type="file" id="importFile" tabindex="-1" />
<a
class="dropdown-item helpButton"
href="#"
data-toggle="modal"
data-target="#helpModal"
onClick="displayUserGuide()"
tabindex="0"
role="menuitem"
>
<i class="fas fa-question-circle"></i>
<i class="fas fa-question-circle" aria-hidden="true"></i>
&nbsp;&nbsp;Help/User Guide</a
>
</div>
Expand Down Expand Up @@ -165,7 +170,7 @@
margin-bottom: -1em;
"
type="button"
class="btn btn-primary"
class="btn btn-primary focus-visible"
aria-label="Select or create your dataset"
>
<i data-feather="chevron-right" class="text-white"></i>
Expand Down