Fixed sufficient color contrast #1035
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
birm
requested changes
Oct 11, 2024
Member
birm
left a comment
birm
left a comment
There was a problem hiding this comment.
Hi and thank you for opening this PR!
Can you open a report or something stating that this fixes color contrast? It doesn't look to me like you're changing color at all.
A list of tools can be found here: https://www.w3.org/WAI/test-evaluate/tools/list/
Contributor
Author
|
Hi, thank you for your feedback! I’ve tested the page using Lighthouse in Chrome DevTools. Initially, Lighthouse flagged poor color contrast (as shown before the fix), but after correcting the colors, the issue no longer appears, meaning the contrast now meets the accessibility standards. Let me know if further clarification is needed! |
birm
approved these changes
Oct 31, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #1034
Element is having low color contrast issue, I have made necessary modifications with font style to meet sufficient color contrast.