Adding Footer to Sign Up Page #635
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
birm
approved these changes
Mar 30, 2023
Member
birm
left a comment
birm
left a comment
There was a problem hiding this comment.
Looks fine to me. At some point we should probably be more visually consistent, but that sounds more like a redesign/refactor for later. Thank you for helping us get there!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
I have added a footer to the sign-up page for improved user experience.
Below are some screenshots
Before
After
Motivation
This Pull Request is motivated by the need to make the website consistent with the application's design. All other pages contain the footer.
Testing
I have tested it on different devices and screen sizes to ensure it is fully responsive.
Questions
Shall the footer be added to the home page too? Are there any links that are to be attached to the footer? Are there any additional changes or improvements that could be made?