Skip to content

Naming only: refer to iipsrv instead of openslide to prevent confusion #651

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
birm merged 1 commit into from
Aug 21, 2023
Merged

Naming only: refer to iipsrv instead of openslide to prevent confusion #651

birm merged 1 commit into from
Aug 21, 2023

Conversation

@CGDogan
Copy link
Contributor

@CGDogan CGDogan commented Aug 19, 2023

This code will also be used for bioformats

birm
birm approved these changes Aug 21, 2023
View reviewed changes
Copy link
Member

@birm birm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this is fine, even though I think it's called openSlide because it opens a slide, and the fact that we use openSlide for iip is just a coincidence (e520806)

In any case, this does resolve ambiguity, so approved.

@birm birm merged commit 3ac47b1 into camicroscope:develop Aug 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@birm birm birm approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@CGDogan @birm