Skip to content

I added aria-label to the buttons #992

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
birm merged 3 commits into from
Jul 5, 2024
Merged

I added aria-label to the buttons #992

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
cef9c57
Add arial-label on buttons
Joice-crypto Jul 2, 2024
e1bafae
Add arial-label on buttons
Joice-crypto Jul 2, 2024
3b28850
Add aria-label on buttons
Joice-crypto Jul 3, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions apps/table.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -315,28 +315,28 @@ function initialize() {

const btn = `<div id='open-delete'>
<button class="btn btn-primary btn-sm" data-id='${sanitize(rs[0])}' onclick='openView(this)'>Open</button>
<button type='button' class='btn btn-primary btn-sm DownloadButton' id='downloadBtn' data-id='${sanitize(rs[0])}' onclick='downloadSlide(this)'>
<button aria-label="Download" type='button' class='btn btn-primary btn-sm DownloadButton' id='downloadBtn' data-id='${sanitize(rs[0])}' onclick='downloadSlide(this)'>
<i class='fas fa-download' ></i>
</button>
${slideDeleteRequests[counter] && slideDeleteRequests[counter].slideDetails &&
slideDeleteRequests.find((o) => o.slideDetails.slideId === rs[0]) ?
`
${slideDeleteRequests.find((o) => o.requestedBy === sanitize(getUserId())) ?
`
<button type='button' class='btn btn-danger btn-sm DelButton' id='deleteBtn' data-id='${sanitize(rs[0])}' data-name='${sanitize(rs[1])}' onclick='deleteSld(this)' data-reqid='${slideDeleteRequests.find((o) => o.slideDetails.slideId === rs[0]) ? slideDeleteRequests.find((o) => o.slideDetails.slideId === rs[0])._id.$oid : ''}' data-filename='${sanitize(filename)}' data-toggle='modal'>
<button aria-label="Delete" type='button' class='btn btn-danger btn-sm DelButton' id='deleteBtn' data-id='${sanitize(rs[0])}' data-name='${sanitize(rs[1])}' onclick='deleteSld(this)' data-reqid='${slideDeleteRequests.find((o) => o.slideDetails.slideId === rs[0]) ? slideDeleteRequests.find((o) => o.slideDetails.slideId === rs[0])._id.$oid : ''}' data-filename='${sanitize(filename)}' data-toggle='modal'>
Cancel Delete Request <i class='fas fa-trash-alt' ></i>
</button>
` :
`
<button disabled type='button' class='btn btn-danger btn-sm tooltipCustom' id='deleteBtn'>
<button aria-label="Delete" disabled type='button' class='btn btn-danger btn-sm tooltipCustom' id='deleteBtn'>
<span class="tooltiptextCustom p-1">Delete requested by ${slideDeleteRequests.find((o) => o.slideDetails.slideId === rs[0]) ? slideDeleteRequests.find((o) => o.slideDetails.slideId === rs[0]).requestedBy : ''}</span>
Delete Requested <i class='fas fa-trash-alt' ></i>
</button>
`
}
` :
`
<button type='button' class='btn btn-danger btn-sm DelButton' id='deleteBtn' data-id='${sanitize(rs[0])}' data-name='${sanitize(rs[1])}' onclick='deleteSld(this)' data-filename='${sanitize(filename)}' data-toggle='modal'>
<button aria-label="Delete" type='button' class='btn btn-danger btn-sm DelButton' id='deleteBtn' data-id='${sanitize(rs[0])}' data-name='${sanitize(rs[1])}' onclick='deleteSld(this)' data-filename='${sanitize(filename)}' data-toggle='modal'>
${permissions.slide.delete == true ? '' : 'Request Deletion'} <i class='fas fa-trash-alt' ></i>
</button>
`
Expand Down