[wont pass tests yet] Proposed factory / auto-subclassing Variable #44
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This won't pass all the tests as-is; it's a proposed interface but it does work with additional small adjustments to vocs.py.
Making the
Variablebase class also a factory class that produces the corresponding subclass when parameterized accordingly. Each subclass naturally validates itself.VOCSloses some validation responsibilities.Each variable itself also has a name and
dtypeas discussed.dtype,default_value's type, and the values withinDiscreteVariableshould naturally match, and validation logic should be written for this.This kind of factory-logic can be extended for the other objects that are currently accepted by VOCS.