-
Notifications
You must be signed in to change notification settings - Fork 4
Make all fields classes with type #45
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #45 +/- ##
==========================================
Coverage 100.00% 100.00%
==========================================
Files 5 5
Lines 458 563 +105
==========================================
+ Hits 458 563 +105 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
From meeting:
|
f02e28d to
5171859
Compare
All fields use classes - with all having a datatype specifiable. Defaults to None.
Targets #40. More complete resolution to #39
Currently takes string for datatype (can add tuple).
to
Update: Objectives now use inherited classes.
Should dtype be string/tuple (numpy centric) or separate type, size fields?
Should we constrain types for variables for instance - somehow?
Can we have a
ContinuousVariableof integer type or should we have separateIntegerVariableas before.If we do like this, we could make
constraintsjustobservableswith an optionalconstraintattribute.