-
Notifications
You must be signed in to change notification settings - Fork 229
fix: return int for process version incident alert #7600
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
mesellings
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@RomanJRW I've added some more detail to the announcement and moved it into the breaking changes section - please check for technical accuracy etc - also, I added a caution to the webhook alerts page itself, but we can remove if you think that is too much? Otherwise, lgtm for a first iteration 🚀
mesellings
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Re-approved after slight rewording
|
@mesellings - the changes are now merged and will be included in the 8.8.9 release. Documentation is good to go from my perspective around the same time as the release announcements |
|
@mesellings - nudging here, should this now be merged? |
|
Thanks for the nudge @RomanJRW - yes I think we can merge this as long as you are happy the changes will be visible before the release on Tuesday? Or we can wait until closer still (e.g. Monday) - we monitor the open PRs so it won't be forgotten if we hold off? |
|
All good for me, thanks for merging 👍 |
|
🧹 Preview environment for this PR has been torn down. |
Description
To be merged with the alpha release in January.
In this PR, we are fixing a regression in the type and content of the process version field. We will also introduce a new version tag field so that this property is still available to customers.
This is the corresponding doc change for that PR.
When should this change go live?
bugorsupportlabel)available & undocumentedlabel)holdlabel)low priolabel)PR Checklist
{type}(scope): {description}commit message(s)/docsdirectory (version 8.9)./versioned_docsdirectory.@camunda/tech-writersunless working with an embedded writer.