Skip to content

Notebook for PDC to CRDCH transformation workflow#37

Merged
gaurav merged 7 commits intomainfrom
spatil/pdc-to-crdch-notebook
Jan 6, 2022
Merged

Notebook for PDC to CRDCH transformation workflow#37
gaurav merged 7 commits intomainfrom
spatil/pdc-to-crdch-notebook

Conversation

@sujaypatil96
Copy link
Contributor

@sujaypatil96 sujaypatil96 commented Nov 16, 2021

Similar to the GDC to CCDH conversion notebook tutorial we have, this PR seeks to demonstrate the same with PDC data.

Note: The data in GDC and PDC is similar for the most part, so most of the snippets were replicated as is.

This PR is by no means complete. A few things that need to be added:

  • Replace the dataclass file being used currently with the latest dataclass file as in the PyPI package
  • Add more documentation

CC: @gaurav @turbomam @jooho-lee-kim. Just wanted to get your eyes on the Notebook is all.

@turbomam
Copy link
Member

turbomam commented Nov 18, 2021

Thanks for starting this @sujaypatil96

You know I get confused easily, so let me know if I'm rehashing something we've already resolved!

Your pdc_to_crdch_transformation notebook imports the CRDC-H model with

from ccdh import ccdhmodel as ccdh

That gets an old version of the model from the cloned repo in the local filesystem.

In order to develop against the latest model as published on PyPI, I would suggest

import crdch_model.crdch_model as ccdh

In which case you will get the following from create_stage_from_pdc()

TypeError: crdch_model.crdch_model.CodeableConcept() argument after ** must be a mapping, not str

@gaurav
Copy link
Collaborator

gaurav commented Nov 18, 2021

That gets an old version of the model from the cloned repo in the local filesystem.

Yeah, it's a little odd that we still have that version rattling around! I'm working on a PR to switch this repo over to Poetry and to delete those files from this repo entirely (#41).

@gaurav gaurav mentioned this pull request Nov 19, 2021
@sujaypatil96 sujaypatil96 marked this pull request as ready for review November 23, 2021 21:16
@sujaypatil96
Copy link
Contributor Author

sujaypatil96 commented Nov 23, 2021

I think this PR is ready for review @turbomam and @gaurav. Would love to hear some thoughts from you guys as to how I can further improve this tutorial.

Perhaps more and better documentation? Better organization of code? etc.

@gaurav gaurav requested review from gaurav and turbomam December 2, 2021 20:38
@gaurav gaurav force-pushed the spatil/pdc-to-crdch-notebook branch from 02e567e to fa1c15d Compare January 6, 2022 21:59
@gaurav gaurav merged commit b5279d6 into main Jan 6, 2022
@gaurav gaurav deleted the spatil/pdc-to-crdch-notebook branch January 6, 2022 22:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants