Skip to content

Fix write() extreme slowdown for filenames containing underscores #69

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
Copilot wants to merge 2 commits into
base: master
Choose a base branch
from
Draft

Fix write() extreme slowdown for filenames containing underscores #69

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
c610c63
Initial plan
Copilot Mar 9, 2026
cd28043
Fix write function performance for filenames with underscores
Copilot Mar 9, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 6 additions & 3 deletions CanlabCore/Index_image_manip_tools/iimg_reconstruct_3dvol.m
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -129,9 +129,9 @@ function write_file(voldata, volInfo, outname, descrip, varargin)
% correct .private loaded from file by re-mapping volume.
spm_write_plane(spm_vol(volInfo.fname), voldata, slice_number);
else
warning('off'); % empty images return many warnings
warnstate = warning('off', 'all'); % empty images return many warnings
spm_write_vol(volInfo, voldata);
warning('on');
warning(warnstate);
end
end

Expand All @@ -149,7 +149,10 @@ function write_file(voldata, volInfo, outname, descrip, varargin)
t = t(1);
n1 = ext((t+1):end);
if ~isempty(n1),
n = str2num(n1);
n = str2double(n1);
if isnan(n)
n = 1; % Fall back to 1 for non-numeric values
end
ext = ext(1:(t-1));
end
end
Expand Down
15 changes: 9 additions & 6 deletions CanlabCore/Index_image_manip_tools/iimg_reconstruct_vols.m
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -232,18 +232,18 @@ function write_file(voldata, volInfo, outname, descrip, varargin)
% write one slice for a series of images
slice_number = varargin{1};

filenames = [];
filenames_cell = cell(nimgs, 1);
for i = 1:nimgs
filenames = char(filenames, make_img_filename(outname, i));
filenames_cell{i} = make_img_filename(outname, i);
end
filenames = filenames(2:end, :);
filenames = char(filenames_cell);

% Note: pinfo is set to [1 0 0] for new images; no rescaling of
% images.
scn_write_plane(filenames, voldata, slice_number, volInfo);

else
warning('off'); % empty images return many warnings
warnstate = warning('off', 'all'); % empty images return many warnings
for i = 1:nimgs
[volInfo.fname, volInfo.n(1)] = make_img_filename(outname, i);
volInfo.descrip = descrip;
Expand All @@ -254,7 +254,7 @@ function write_file(voldata, volInfo, outname, descrip, varargin)

spm_write_vol(volInfo, squeeze(voldata(:, :, :, i)));
end
warning('on');
warning(warnstate);
end
end

Expand All @@ -278,7 +278,10 @@ function write_file(voldata, volInfo, outname, descrip, varargin)
t = t(1);
n1 = ext((t+1):end);
if ~isempty(n1),
n = str2num(n1);
n = str2double(n1);
if isnan(n)
n = imagenum; % Fall back to imagenum for non-numeric values
end
ext = ext(1:(t-1));
end
else
Expand Down