Skip to content

puppet config: add the start_agent option#1002

Merged
TheRealFalcon merged 3 commits into
canonical:mainfrom
andrewbogott:puppetservice
Sep 1, 2021
Merged

puppet config: add the start_agent option#1002
TheRealFalcon merged 3 commits into
canonical:mainfrom
andrewbogott:puppetservice

Conversation

@andrewbogott
Copy link
Copy Markdown
Contributor

The current code starts the puppet agent and also sets autostart
in all cases. This conflicts with a common pattern where puppet
itself manages the agent and autostart state.

For example, in my deploy puppet disables the puppet agent
and replaces it with a cron. This causes various races
both within this cloud-init unit and within puppet itself
while cloud-init and puppet fight over whether or not
to enable the service.

Proposed Commit Message

puppet config: add the 'start_agent' option

this can be used in combination with the 'exec' option to perform a single
synchronous puppet run and then leave whatever happens next to
the system config as dictated by puppet.

Checklist:

  • My code follows the process laid out in the documentation
  • I have updated or added any unit tests accordingly
  • I have updated or added any documentation accordingly

Andrew Bogott and others added 2 commits August 26, 2021 14:09
The current code starts the puppet agent and also sets autostart
in all cases. This conflicts with a common pattern where puppet
itself manages the agent and autostart state.

For example, in my deploy puppet disables the puppet agent
and replaces it with a cron. This causes various races
both within this cloud-init unit and within puppet itself
while cloud-init and puppet fight over whether or not
to enable the service.
Copy link
Copy Markdown
Contributor

@TheRealFalcon TheRealFalcon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants