Add retries to DataSourceGCE.py when connecting to GCE#1005
Conversation
blackboxsw
left a comment
There was a problem hiding this comment.
Thanks you for this submission @vteratipally. I've confirmed that you have signed the cloud-init Contributor Agreement.
I've provided a couple of comments about how we can best add this retry logic to GCE in a way that aligns with how other datasources instrument this setting in a more flexible way.
Please also add the following:
- your github username alphabetically in ./tools/.github-cla-signers
- unit test coverage of these changes if you can in tests/unittests/test_datasource/test_gce.py
- documentation update to doc/rtd/topics/datasources/gce.rst with a new section called
Configuration
-------------
The following configuration can be set for the datasource in system
configuration (in `/etc/cloud/cloud.cfg` or `/etc/cloud/cloud.cfg.d/`).
The settings that may be configured are:
...
See either doc/rtd/topics/datasources/openstack.rst or doc/rtd/topics/datasources/ec2.rst for examples of the markdown in this section.
blackboxsw
left a comment
There was a problem hiding this comment.
Changes, docs and tests look good to me. will test this tomorrow and approve if no other concerns. Much thanks @vteratipally
blackboxsw
left a comment
There was a problem hiding this comment.
After long delay, finally got round to validating behavior on GCP. Thank you, thank you for this change and your patience.
|
thank you @blackboxsw |
Add retries to DataSourceGCE.py when connecting to GCE
Additional Context
Checklist: