Improve ug_util.py

[sshedi]

Signed-off-by: Shreenidhi Shedi sshedi@vmware.com

Improve ug_util.py

[TheRealFalcon]

Thanks for the refactor. I left two nits inline, but I'm ok merging without them.

Some of these changes definitely make the code clearer (removing unnecessary len() calls, simplying if blocks and loops, etc), but some are also purely cosmetic (comment line length, single vs double quotes, removing unnecessary parens). In general, in the future, I think I'd prefer to only make cosmetic changes if we're modifying the code in question, especially since we're likely to adopt black at some point in the future.

[sshedi]

Thanks for the refactor. I left two nits inline, but I'm ok merging without them.

Some of these changes definitely make the code clearer (removing unnecessary len() calls, simplying if blocks and loops, etc), but some are also purely cosmetic (comment line length, single vs double quotes, removing unnecessary parens). In general, in the future, I think I'd prefer to only make cosmetic changes if we're modifying the code in question, especially since we're likely to adopt black at some point in the future.

I understand. There were some typos and other mistakes in comments so I started fixing them and ended up making modifications in all places. But your suggestion is valid, I will keep it in mind.