Remove invalid ssh_import_id from examples#1031
Merged
Merged
Conversation
blackboxsw
requested changes
Sep 24, 2021
Collaborator
blackboxsw
left a comment
blackboxsw
left a comment
There was a problem hiding this comment.
Let's make our examples the correct type since they are examples :)
| selinux_user: staff_u | ||
| expiredate: '2032-09-01' | ||
| ssh_import_id: foobar | ||
| ssh_import_id: <Launchpad/Github id> |
Collaborator
There was a problem hiding this comment.
These examples are incorrect as ssh_import_id needs to be a list.
Since these are two examples, maybe we could make them explicit for either gh: or lp:?
Suggested change
| ssh_import_id: <Launchpad/Github id> | |
| ssh_import_id: [lp:falcojr, gh:TheRealFalcon] |
Contributor
Author
|
Strings work too, but I updated the examples to be more inline with work you're looking for. |
TheRealFalcon
force-pushed
the
invalid-examples
branch
from
a830143 to
019546b
Compare
blackboxsw
approved these changes
Sep 24, 2021
Collaborator
blackboxsw
left a comment
blackboxsw
left a comment
There was a problem hiding this comment.
Oops right! JSON schema needed here FTW :/
This was referenced May 12, 2023
Closed
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Proposed Commit Message
Additional Context
Nonecould be taken to mean, "this is valid but do nothing", but actually specifying None will give an error in the logs.@akutz requested I remove the VMWare references as well.
We use
<ssh pub key 1>in the examples, so I figure using a non-real<Launchpad/Github id>is fine.