Skip to content

renderer: convert relative imports to absolute#1052

Merged
blackboxsw merged 1 commit into
canonical:mainfrom
paride:renderer-absolute-import
Oct 7, 2021
Merged

renderer: convert relative imports to absolute#1052
blackboxsw merged 1 commit into
canonical:mainfrom
paride:renderer-absolute-import

Conversation

@paride
Copy link
Copy Markdown
Contributor

@paride paride commented Oct 7, 2021

Proposed Commit Message

renderer: convert relative imports to absolute

Fixes the following pylint error:

cloudinit/net/renderer.py:12: [E0611(no-name-in-module), ]
  No name 'generate_udev_rule' in module 'udev'

Likely a false positive, but we don't really need to keep the imports
relative, so let's convert them to absolute as a workaround.

Additional Context

First seen in #1050 which only touches unrelated code.

Test Steps

tox -e pylint

Checklist:

  • My code follows the process laid out in the documentation
  • I have updated or added any unit tests accordingly
  • I have updated or added any documentation accordingly

Fixes the following pylint error:

cloudinit/net/renderer.py:12: [E0611(no-name-in-module), ]
  No name 'generate_udev_rule' in module 'udev'

Likely a false positive, but we don't really need to keep the imports
relative, so let's convert them to absolute as a workaround.
Copy link
Copy Markdown
Collaborator

@blackboxsw blackboxsw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

GREAT WORK @paride.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants