Skip to content

VMware: read network-config from ISO#1066

Merged
TheRealFalcon merged 2 commits into
canonical:mainfrom
t-8ch:feature/vmware/network-from-iso
Oct 19, 2021
Merged

VMware: read network-config from ISO#1066
TheRealFalcon merged 2 commits into
canonical:mainfrom
t-8ch:feature/vmware/network-from-iso

Conversation

@t-8ch
Copy link
Copy Markdown
Contributor

@t-8ch t-8ch commented Oct 13, 2021

Proposed Commit Message

There is no reason for the ISO missing this functionality.

As discussed in https://github.com/canonical/cloud-init/pull/947/files#r707338489

Test Steps

  1. Create a ovf-env.xml which includes 'network-config' Property
  2. Set 'network-config' Property's value to base64 encoded network config
  3. Create OVF ISO containing ovf-env.xml
  4. Verify cloud-init can get network config from OVF ISO

Checklist:

  • My code follows the process laid out in the documentation
  • I have updated or added any unit tests accordingly
  • I have updated or added any documentation accordingly

Cc @PengpengSun

@TheRealFalcon
Copy link
Copy Markdown
Contributor

@t-8ch , thanks for the PR.

I noticed you signed the CLA, but haven't yet added yourself to the CLA signers file. As part of this PR, please also add your name (alphabetically) to the CLA signers file. The full details are described in the last bullet point of the documentation.

@t-8ch
Copy link
Copy Markdown
Contributor Author

t-8ch commented Oct 15, 2021

@TheRealFalcon done

@TheRealFalcon
Copy link
Copy Markdown
Contributor

hey @t-8ch ,we had a CI failure on main (unrelated to this code), so your branch needs to be rebased in order for CI to pass.

@t-8ch t-8ch force-pushed the feature/vmware/network-from-iso branch from b9b71f0 to cb8fb1e Compare October 18, 2021 17:05
@t-8ch
Copy link
Copy Markdown
Contributor Author

t-8ch commented Oct 18, 2021

@TheRealFalcon done

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants