Skip to content

add google while checking the pname#1077

Merged
TheRealFalcon merged 1 commit into
canonical:mainfrom
vteratipally:add-google
Oct 22, 2021
Merged

add google while checking the pname#1077
TheRealFalcon merged 1 commit into
canonical:mainfrom
vteratipally:add-google

Conversation

@vteratipally
Copy link
Copy Markdown
Contributor

@vteratipally vteratipally commented Oct 22, 2021

Proposed Commit Message

Add google while checking the pname

In some of the cases, the system-product-name is just google.
This is useful incase of nocloud where we use the disk to load the datasource

Test Steps

  • Tested on the product in which the pname returns "Google"
  • Validating in a mock environment.

Checklist:

  • My code follows the process laid out in the documentation
  • I have updated or added any unit tests accordingly
  • I have updated or added any documentation accordingly

@TheRealFalcon
Copy link
Copy Markdown
Contributor

Where are you seeing it returned as "Google"? Is it actually happening on the Google platform (and if so, under what circumstances)? You mention a mock environment. If this is for a mock environment, can't you mock it to return "Google Compute Engine"?

@vteratipally
Copy link
Copy Markdown
Contributor Author

vteratipally commented Oct 22, 2021

Yes it is actually happen on the google platform but only for few services. This particular patch is maintained internally but would like to keep the oss updated. https://cos.googlesource.com/cos/overlays/board-overlays/+/refs/heads/master/project-lakitu/app-emulation/cloud-init/files/21.2-datasource-gce-platform-google.patch

Copy link
Copy Markdown
Contributor

@TheRealFalcon TheRealFalcon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I see, that makes sense. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants