Remove pin in dependencies for jsonschema (SC-508)#1078
Merged
Conversation
TheRealFalcon
changed the title
blackboxsw
approved these changes
Oct 23, 2021
Collaborator
blackboxsw
left a comment
blackboxsw
left a comment
There was a problem hiding this comment.
+1. Not really gaining a whole lot by the hostname validation.
holmanb
pushed a commit
to holmanb/cloud-init
that referenced
this pull request
Nov 1, 2021
In jsonschema 4, hostname validation was changed to have an optional dependency on the fqdn package. Since we don't have this dependency in cloud-init, attempting this validation will no longer fail for a string that isn't a valid hostname.
This was referenced May 12, 2023
Closed
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Additional Context
This is to fix two failing unit tests.
Are we ok with this validation being disabled? It is currently in use in cc_ntp.py. Nothing is broken by it not being there, it will just validate it as a string rather than as a hostname.