Allow libexec for hotplug (SC-532)#1088
Merged
Merged
Conversation
TheRealFalcon
changed the title
blackboxsw
approved these changes
Oct 29, 2021
Collaborator
blackboxsw
left a comment
blackboxsw
left a comment
There was a problem hiding this comment.
+1 this is a reasonable runtime approach to installing to the right path
| log.debug("Skipping hotplug install, udevadm not found") | ||
| return | ||
|
|
||
| # This may need to turn into a distro property at some point |
Collaborator
There was a problem hiding this comment.
+1 I'm good with this approach. Checking /usr/libexec dir first would allow us to prefer that on distros that have installed cloud-init to that path.
When we added the install hotplug module, we forgot to update the redhet/cloud-init.spec.in file and allow for execution on /usr/libexec. This PR adds that functionality
TheRealFalcon
force-pushed
the
hotplug-copr
branch
from
6ef1bab to
9071b08
Compare
TheRealFalcon
changed the title
This was referenced May 12, 2023
Closed
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Proposed Commit Message
Additional Context
Test Steps
Verified rpm package builds,
/etc/udev/rules.d/10-cloud-init-hook-hotplug.rulesgets written and references/usr/libexec/cloud-init/hoook-hotplugand/usr/libexec/cloud-init/hook-hotplugexists. Also tested that integration test still passes on ubuntu.Checklist: