testing: Remove calls to 'install_new_cloud_init'#1092
Merged
Conversation
In our integration tests, a few tests were modifying the environment and then calling 'install_new_cloud_init'. This is problematic because it updates the environment for all future tests. Other instances of 'install_new_cloud_init' aren't problematic because they aren't modifying the underlying environment.
TheRealFalcon
commented
Nov 2, 2021
| @pytest.mark.lxd_vm | ||
| @pytest.mark.ubuntu # Because netplan | ||
| def test_lxd_datasource_discovery(session_cloud: IntegrationCloud): | ||
| def test_lxd_datasource_discovery(client: IntegrationInstance): |
Contributor
Author
There was a problem hiding this comment.
Most of the changes in this test are just indentation
Contributor
Author
|
I had a successful local lxd_container run with the daily-ppa on impish. |
blackboxsw
approved these changes
Nov 2, 2021
Collaborator
blackboxsw
left a comment
blackboxsw
left a comment
There was a problem hiding this comment.
Thanks for the fix. Makes sense here that we no longer modify the base image under test :(.
This was referenced May 12, 2023
Closed
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Proposed Commit Message
Additional Context
Test Steps
Since this involves one test affecting tests run after it, the whole suite of tests was run for lxd containers. I also verified the updated GCE test on GCE.
Checklist: