Some miscellaneous integration test fixes (SC-606)#1103
Merged
Conversation
TheRealFalcon
force-pushed
the
integration-test-fixes
branch
4 times, most recently
from
ab3c669 to
f6a40cd
Compare
- Added to list of expected warnings on Oracle when opc user has no ssh key - Added retries to tests that read from syslog as that can sometimes take time to reflect in the log - Updated test_apt.py to remove proxy info into its own test as that can cause failures in updating, which will immediately traceback out of the module and prevent us from running further class tests - Updated test_apt.py to use a more updated ppa in the test_keyserver - Added basic rsyslog test to test_combined.py - Added basic puppet test as test_puppet.py
TheRealFalcon
force-pushed
the
integration-test-fixes
branch
from
f6a40cd to
78c8019
Compare
TheRealFalcon
changed the title
TheRealFalcon
changed the title
blackboxsw
reviewed
Nov 15, 2021
Collaborator
blackboxsw
left a comment
blackboxsw
left a comment
There was a problem hiding this comment.
Nice integration test adds. Minor typo, and future suggestion for cloud-awareness in verify_clean_logs.
| # - name: opc | ||
| # ssh_redirect_user: true | ||
| # This can trigger a warning about opc having no public key | ||
| warning_texts.append( |
Collaborator
There was a problem hiding this comment.
Not a big deal for this integration test, but seems like we might want instance.cloud awareness in verify_clean_logs for azure vs oracle cases. But, this can wait until we have a third use-case.
holmanb
approved these changes
Nov 15, 2021
Contributor
Author
|
@blackboxsw , Fixed the typo |
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Proposed Commit Message