add 21.4 tests (SC-609)#1104
Merged
Merged
Conversation
holmanb
force-pushed
the
holmanb/growpart
branch
2 times, most recently
from
817a7ca to
2919fb4
Compare
TheRealFalcon
suggested changes
Nov 15, 2021
Contributor
TheRealFalcon
left a comment
TheRealFalcon
left a comment
There was a problem hiding this comment.
Nice test additions/changes. Thanks!
My only request is an additional check on the integration that we actually did what we said we did in the log.
Member
Author
|
I resolved the merge conflict and addressed the requests. I think this is ready for review / merge. |
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Test Steps
set PLATFORM = 'lxd_vm' for the integration test
Checklist: