tests: specialize lxd_discovery test for lxd_vm vendordata#1106
Merged
Conversation
blackboxsw
force-pushed
the
lxd-test-bionic
branch
from
ba44484 to
a0e042a
Compare
On Bionic and Xenial, pycloudlib sets user.vendor-data config in lxd to ensure that lxd-agent is setup on those images. Adapt the lxd_discovery integration test to assert the appropriate user.vendor-data config key exists if we are on xenial or bionic. Also add assertions that /var/lib/cloud/nocloud-net/meta-data still exists in the images because we want NoCloud to be a viable fallback datasource if LXD config security.lxddev = false or LXD datasource discovery encountered an unexpected error.
blackboxsw
force-pushed
the
lxd-test-bionic
branch
from
a0e042a to
d8d0109
Compare
TheRealFalcon
approved these changes
Nov 11, 2021
Contributor
TheRealFalcon
left a comment
TheRealFalcon
left a comment
There was a problem hiding this comment.
Verified LXD VM and LXD containers.
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Proposed Commit Message
Additional Context
pycloudlib has special vendor-data treatment on Xenial and Bionic
Test Steps
.tox/integration-tests/bin/pytest tests/integration_tests/datasources/test_lxd_discovery.py ## or ## CLOUD_INIT_SOURCE=lxd_vm .tox/integration-tests/bin/pytest tests/integration_tests/datasources/test_lxd_discovery.pyChecklist: