lxd: add preference for LXD cloud-init.* config keys over user keys#1108
Merged
Conversation
TheRealFalcon
suggested changes
Nov 16, 2021
Contributor
TheRealFalcon
left a comment
TheRealFalcon
left a comment
There was a problem hiding this comment.
Looks good. Only major comment is the warning.
| # the dict path {LXD_SOCKET_API_VERSION: {config: {...}}. | ||
| response = session.get(config_url) | ||
| LOG.debug("[GET] [HTTP:%d] %s", response.status_code, config_url) | ||
| if not response.ok: |
Contributor
There was a problem hiding this comment.
Nice additional error checking in this section
| assert 0 == m_lstat.call_count | ||
|
|
||
|
|
||
| class TestReadMetadata: |
Contributor
There was a problem hiding this comment.
I really like how this test is structured.
blackboxsw
force-pushed
the
lxd-ds
branch
2 times, most recently
from
aa59b2c to
b4e79b9
Compare
LXD now adds cloud-init scoped configuration keys network-config, user-data and vendor-data. The existing user.user-data, user.vendor-data, user.network-config and meta-data will be deprecated in newer LXD. cloud-init will prefer LXD config keys cloud-init.* keys above user.* keys even if both are present. Expectation is that the configuration user.network-config, user.meta-data, user.user-data and user.vendor-data* keys should not be present at the same time as the comparable cloud-init.* keys.
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Proposed Commit Message
Additional Context
Test Steps
Checklist: